Support Python 3.10-rc.1 #1147
Merged
Support Python 3.10-rc.1 #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
reviewed
Aug 13, 2021
| @@ -88,6 +88,7 @@ def get_packages(package): | |||
| "Programming Language :: Python :: 3.7", | |||
| "Programming Language :: Python :: 3.8", | |||
| "Programming Language :: Python :: 3.9", | |||
| "Programming Language :: Python :: 3.10", | |||
There was a problem hiding this comment.
Suggested change
| "Programming Language :: Python :: 3.10", |
we can't add the trove until python-websockets/websockets#1000 is on pypi
There was a problem hiding this comment.
But they have added as well https://github.com/aaugustin/websockets/blob/6edb363af07365867b4c372405b6ab3177a57830/setup.py#L53
There was a problem hiding this comment.
Ah, it's on master.
There was a problem hiding this comment.
But websockets is not a mandatory dependency, so it shouldn't be a blocker, right?
graingert
approved these changes
Aug 13, 2021
|
Thanks @graingert ! I guess you'll bump the websockets on a new PR? |
Kludex
added a commit
that referenced
this pull request
Nov 17, 2021
Kludex
added a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.