Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix the need of httptools on minimal installation #1135

Merged
merged 1 commit into from Jul 30, 2021
Merged

馃悰 Fix the need of httptools on minimal installation #1135

merged 1 commit into from Jul 30, 2021

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Jul 23, 2021

This solves the following bug, caused when you installed uvicorn via pip install uvicorn.

>>> import uvicorn
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/marcelo/Development/encode/uvicorn/uvicorn/__init__.py", line 2, in <module>
    from uvicorn.main import Server, main, run
  File "/home/marcelo/Development/encode/uvicorn/uvicorn/main.py", line 23, in <module>
    from uvicorn.server import Server, ServerState  # noqa: F401  # Used to be defined here.
  File "/home/marcelo/Development/encode/uvicorn/uvicorn/server.py", line 19, in <module>
    from uvicorn.protocols.http.httptools_impl import HttpToolsProtocol
  File "/home/marcelo/Development/encode/uvicorn/uvicorn/protocols/http/httptools_impl.py", line 8, in <module>
    import httptools
ModuleNotFoundError: No module named 'httptools'

@Kludex Kludex requested a review from euri10 July 23, 2021 09:31
@Kludex Kludex mentioned this pull request Jul 23, 2021
1 task
Copy link
Member

@euri10 euri10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kludex Kludex merged commit e65ec3d into encode:master Jul 30, 2021
@Kludex
Copy link
Sponsor Member Author

Kludex commented Jul 30, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants