Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project links on setup.py for PyPI #1133

Merged
merged 1 commit into from Jul 30, 2021
Merged

Add project links on setup.py for PyPI #1133

merged 1 commit into from Jul 30, 2021

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Jul 22, 2021 •
edited

Idea "copied" from django-rest-framework thanks to @graingert points. :)

@Kludex Kludex changed the title ♿️ Add more URLs information on setup.py for PyPI ♿️ Add more uvicorn links on setup.py for PyPI Jul 22, 2021
@Kludex Kludex changed the title ♿️ Add more uvicorn links on setup.py for PyPI ♿️ Add project links on setup.py for PyPI Jul 22, 2021
graingert
graingert reviewed Jul 30, 2021
View reviewed changes
setup.py
@@ -95,4 +95,8 @@ def get_packages(package):
[console_scripts]
uvicorn=uvicorn.main:main
""",
project_urls={
"Funding": "https://github.com/sponsors/encode",
"Source": "https://github.com/encode/uvicorn",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog?

graingert
graingert requested changes Jul 30, 2021
View reviewed changes
Copy link
Member

@graingert graingert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog?

@euri10
Copy link
Member

euri10 commented Jul 30, 2021

Changelog?

agreed, that goes with my comment here #1134

@euri10
Copy link
Member

euri10 commented Jul 30, 2021

also my brain farts seeing that many emojis in PR titles, but this is unrelated

@graingert graingert self-requested a review July 30, 2021 06:54
@Kludex
Copy link
Sponsor Member Author

Kludex commented Jul 30, 2021

@euri10 I can stop using gitmoji if it bothers you. I don't mind. Just let me know 😗

@graingert
Copy link
Member

I'm not sure what ♿ means in terms of setup.py change. This is because it changes wheel metadata?

@Kludex
Copy link
Sponsor Member Author

Kludex commented Jul 30, 2021

Well, maybe it was not the best choice... That one means "improve accessibility". But it could be the 📦.

Ref.: https://gitmoji.dev/

@euri10
Copy link
Member

euri10 commented Jul 30, 2021

@euri10 I can stop using gitmoji if it bothers you. I don't mind. Just let me know

you do as you want @Kludex I just find all those emoji eveywhere for everything quite unreadable, unnecessary.
good read: https://www.tandfonline.com/doi/abs/10.1080/014492999119129

@Kludex
Copy link
Sponsor Member Author

Kludex commented Jul 30, 2021

I'm going to read it later. Thanks!

But as I said, I don't mind. So if it's improve your experience, I'll stop using it.

@Kludex Kludex changed the title ♿️ Add project links on setup.py for PyPI Add project links on setup.py for PyPI Jul 30, 2021
@Kludex Kludex merged commit acb37bb into encode:master Jul 30, 2021
Kludex added a commit that referenced this pull request Nov 17, 2021
@Kludex
Add more URLs information on setup.py for PyPI (#1133)
3afde18
Kludex added a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
@Kludex
Add more URLs information on setup.py for PyPI (encode#1133)
ab2dd20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graingert graingert graingert approved these changes

@euri10 euri10 euri10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kludex @euri10 @graingert