✏️ Fix ping parameters annotation in Config class #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/aaugustin/websockets/blob/361f38066622636eff8d9e0d3d071e93e8e02b05/src/websockets/legacy/protocol.py#L1097 actually pretty sure they should be optional to allow for disabling ping? |
graingert
reviewed
Jul 18, 2021
uvicorn/config.py
Outdated
| @@ -145,8 +145,8 @@ def __init__( | |||
| http: Union[Type[asyncio.Protocol], HTTPProtocolType] = "auto", | |||
| ws: Union[Type[asyncio.Protocol], WSProtocolType] = "auto", | |||
| ws_max_size: int = 16 * 1024 * 1024, | |||
| ws_ping_interval: int = 20, | |||
| ws_ping_timeout: int = 20, | |||
| ws_ping_interval: float = 20, | |||
There was a problem hiding this comment.
graingert
requested changes
Jul 18, 2021
graingert
approved these changes
Jul 18, 2021
|
@graingert True! Thanks for the review! I'm going to push the fix later on. |
Kludex
changed the title
Kludex
added a commit
that referenced
this pull request
Nov 17, 2021
* ✏️ Fix Config init function annotation * add optional to ping parameters
Kludex
added a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
* ✏️ Fix Config init function annotation * add optional to ping parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hard to find 😅