Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TLS ASGI extension #1118

Open
2 tasks done
mdgilene opened this issue Jul 10, 2021 · 2 comments · May be fixed by #1119
Open
2 tasks done

Implement TLS ASGI extension #1118

mdgilene opened this issue Jul 10, 2021 · 2 comments · May be fixed by #1119
Labels
asgi enhancement

Comments

@mdgilene
Copy link

mdgilene commented Jul 10, 2021 •
edited by polar-sh bot

Checklist

  • There are no similar issues or pull requests for this yet.
  • I discussed this idea on the community chat and feedback is positive.

Is your feature related to a problem? Please describe.

No

Describe the solution you would like.

Implementation of the TLS ASGI extension. Recently this extension has been formalized via django/asgiref#192. It would be nice to get this implemented in Uvicorn so that applications can start using this info.

Describe alternatives you considered

N/A

Important

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@Kludex
Copy link
Sponsor Member

Kludex commented Jul 10, 2021

PR is welcome. We are blocked until next asgiref release.

@mdgilene mdgilene linked a pull request Jul 11, 2021 that will close this issue
Open
@Kludex Kludex added the asgi label Sep 18, 2021
@brussee
Copy link

brussee commented Feb 18, 2022

@Kludex wrote:

PR is welcome. We are blocked until next asgiref release.

I noticed the ASGI TLS Extension version 0.2 (2020-10-02) was merged on 2021-07-10 and subsequently a new asgiref version 3.5.0 was recently released on 2022-01-22. Does this mean we are no longer blocked and this PR of @mdgilene can be polished and merged? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
asgi enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement asgiref tls extension mdgilene/uvicorn
3 participants
@brussee @Kludex @mdgilene