test under py3.10 #1070
test under py3.10 #1070
Conversation
graingert
force-pushed
the
avoid-deprecated-get-event-loop
branch
from
9092c9e
to
73dc7e9
Compare
graingert
force-pushed
the
avoid-deprecated-get-event-loop
branch
from
73dc7e9
to
a51908a
Compare
|
I've played a little with 3.10 and the test suite, it seems to me those changes makes sense, however there is a bunch of tests that will fail on 3.10 mainly on the way we setup the loop and get access to it (and on ssl protocol not set but it's unrelated to that and I think the fix is simpler), and unfortunately the PR does not solve it. |
|
I had to cancel the workflow for both Windows and Ubuntu 3.10, jfyk. EDIT: Due to infinite loop... It was consuming our quota 😗 |
a certificate authority cert cannot be used to verify server connections
|
PR for httpx here: encode/httpx#1671 |
There was a problem hiding this comment.
Looks very good to me, approved and many thanks for that @graingert !
I just have one minor question / issue since I'm no semver pro, but would the ssl min default that is bumped from PROTOCOL_SSLv23 to PROTOCOL_TLS_SERVER qualify for a minor version bump or we good with just a patch ?
tests/test_auto_detection.py
Outdated
| @@ -41,15 +43,17 @@ def test_loop_auto(): | |||
| loop.close() | |||
There was a problem hiding this comment.
@euri10 what's this for asyncio.get_event_loop() can't be called here
|
The tests hang due to: |
graingert
force-pushed
the
avoid-deprecated-get-event-loop
branch
from
a0c988a
to
011ae96
Compare
graingert
force-pushed
the
avoid-deprecated-get-event-loop
branch
from
4701cbe
to
b35ac26
Compare
| else: | ||
| loop = asyncio.new_event_loop() | ||
| asyncio.set_event_loop(loop) |
There was a problem hiding this comment.
This is the cause of the httpx tests failing. @tomchristie
There was a problem hiding this comment.
Thanks @Kludex - No idea how you tracked that down, but... 👍
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
in 3.10 running asyncio.get_event_loop() when asyncio.get_running_loop() would fail is deprecated https://docs.python.org/3.10/library/asyncio-eventloop.html#asyncio.get_event_loop