New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to set websocket ping interval and timeout #1048
Conversation
Would love to see this merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@euri10 Just that small issue, and it's fine.
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
done ! that's why another pair of eyes is so important >_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those two as well. But I'll let my approval so you can merge after fixing it. ✌️
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
* Add max size to webosckets implementation * Adde ping interval and timeout to websockets inplmenetation * Post-merge glitches corrected * Added some docs * Corrected flags Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com> * Corrected flags Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com> * Updated docs * Update docs/settings.md Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com> * Update docs/settings.md Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com> Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
@euri10 |
* Add max size to webosckets implementation * Adde ping interval and timeout to websockets inplmenetation * Post-merge glitches corrected * Added some docs * Corrected flags Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com> * Corrected flags Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com> * Updated docs * Update docs/settings.md Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com> * Update docs/settings.md Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com> Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Fixes #245
I tested this manually and can see ping/pong frames flying when I set it to a low interval, but could not find a clever way to add tests as I do not know exactly what should be tested since the ping/pong mechanism is automatically handled by websockets, maybe someone would have an idea