Improve user feedback if no ws library installed #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euri10
reviewed
May 20, 2021
There was a problem hiding this comment.
LGTM
There's been a lot of discussion around this in #926 with @florimondmanca and the consensus was to be less deceptive (ie put a warning message when a user attempts a ws connection without a library) instead of put a warning message every time (which would be the behavior if we put the message above, would it be ?)
Any thoughts on this @florimondmanca , this is the case here a user doesn't install like we advertise, which can and will happen anyway so why not handle that case gently as well.
euri10
approved these changes
May 27, 2021
|
thanks @Vibhu-Agarwal |
Kludex
pushed a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1022
I've just duplicated the work done in #926
Should we move this logic to a central place like
protocols/utils.py?