Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax click version upper bound #1016

Closed
szeleeteo opened this issue Apr 10, 2021 · 6 comments
Closed

Relax click version upper bound #1016

szeleeteo opened this issue Apr 10, 2021 · 6 comments

Comments

@szeleeteo
Copy link

Uvicorn can only use click package version 7.* as defined in setup.py

minimal_requirements = [
    "click==7.*",
    ...
]

However, there is currently a pre-release version 8.0.0a1 which fixes many issues

Would like to request for uvicorn to relax the upper bound for click requirement, such that user can optionally use click version 8 if applicable

minimal_requirements = [
    "click>=7.*"
    ...
]
mariobriggs added a commit to mariobriggs/uvicorn that referenced this issue May 9, 2021
@mariobriggs
Copy link

opened a PR

@epogrebnyak
Copy link

epogrebnyak commented May 14, 2021

However, there is currently a pre-release version 8.0.0a1 which fixes many issues

Just to mention for the purposes of #1033 - Click 8.0.0 is a major release since May 11, so locking at 7.* needs an update.

@epogrebnyak
Copy link

My temp solution is poetry add click=7.*

@mariobriggs
Copy link

click v8.0.0 released 2 days ago

simonw added a commit to simonw/uvicorn that referenced this issue May 23, 2021
@simonw
Copy link
Contributor

simonw commented May 23, 2021

This is blocking me from upgrading Datasette to Click 8.0, since Datasette has uvicorn as a dependency.

euri10 pushed a commit that referenced this issue May 23, 2021
@euri10
Copy link
Member

euri10 commented May 27, 2021

closed by #1042

@euri10 euri10 closed this as completed May 27, 2021
Kludex pushed a commit to sephioh/uvicorn that referenced this issue Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants