New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Config.env_prefix option #1990
Add Config.env_prefix option #1990
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex-oleshkevich If you don't mind, would you be able to give a bit more about the motivation here?
This is a pretty straightforward feature, but no one ever asked before.
This is a common practice to avoid naming conflicts. This situation pretty common in non-docker environments. Or, it may happen in docker-compose when 2 services require the same variable but with different value. These are basically two examples I recall so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's go. 🤷
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Please check if the documentation changes that I suggested work, it may need a plugin. 👀 |
* add Config.env_prefix option * fix variable name in docs * simplify test case * rollback markdown formatting * Update docs/config.md Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com> Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
* add Config.env_prefix option * fix variable name in docs * simplify test case * rollback markdown formatting * Update docs/config.md Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com> Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
This PR adds
Config.env_prefix
argument.