From 1e375b4d10e3b07ae713515dfe32d109cbc9c19b Mon Sep 17 00:00:00 2001 From: Amin Alaee Date: Sat, 26 Jun 2021 11:02:13 +0430 Subject: [PATCH 1/2] make-jinja2-get-env-internal --- starlette/templating.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/starlette/templating.py b/starlette/templating.py index 64fdbd14f..d80f31673 100644 --- a/starlette/templating.py +++ b/starlette/templating.py @@ -56,9 +56,9 @@ class Jinja2Templates: def __init__(self, directory: str) -> None: assert jinja2 is not None, "jinja2 must be installed to use Jinja2Templates" - self.env = self.get_env(directory) + self.env = self._get_env(directory) - def get_env(self, directory: str) -> "jinja2.Environment": + def _get_env(self, directory: str) -> "jinja2.Environment": @pass_context def url_for(context: dict, name: str, **path_params: typing.Any) -> str: request = context["request"] From 4878ba1a48d9db1593bc93b5adabd61e60e96d73 Mon Sep 17 00:00:00 2001 From: Amin Alaee Date: Sat, 26 Jun 2021 18:04:21 +0430 Subject: [PATCH 2/2] rename _get_env to _create_env --- starlette/templating.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/starlette/templating.py b/starlette/templating.py index d80f31673..36f613fdf 100644 --- a/starlette/templating.py +++ b/starlette/templating.py @@ -56,9 +56,9 @@ class Jinja2Templates: def __init__(self, directory: str) -> None: assert jinja2 is not None, "jinja2 must be installed to use Jinja2Templates" - self.env = self._get_env(directory) + self.env = self._create_env(directory) - def _get_env(self, directory: str) -> "jinja2.Environment": + def _create_env(self, directory: str) -> "jinja2.Environment": @pass_context def url_for(context: dict, name: str, **path_params: typing.Any) -> str: request = context["request"]