Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wsgi PATH_INFO encoding #998

Merged
merged 4 commits into from Jul 15, 2020
Merged

fix wsgi PATH_INFO encoding #998

merged 4 commits into from Jul 15, 2020

Conversation

abersheeran
Copy link
Member

fix #997

@JayH5
Copy link
Member

JayH5 commented Jul 15, 2020 •
edited

👋 thanks @abersheeran, if you have time would it be possible to add a test? I see this change has been made in a few other ASGI projects. We could have a test similar to the one in hypercorn

JayH5
JayH5 approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@JayH5 JayH5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know I could add the test myself and now have. Thanks for the pull request.

@JayH5 JayH5 merged commit 85b9c26 into encode:master Jul 15, 2020
@CoolSpring8 CoolSpring8 mentioned this pull request Feb 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayH5 JayH5 JayH5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WSGI Middleware Error in non-ascii path
2 participants
@abersheeran @JayH5