Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add onegraph enhanced graphiql to included graphiql #698

Closed
seandavi opened this issue Oct 29, 2019 · 4 comments
Closed

[Feature] Add onegraph enhanced graphiql to included graphiql #698

seandavi opened this issue Oct 29, 2019 · 4 comments
Labels
feature New feature or request

Comments

@seandavi
Copy link

See https://github.com/OneGraph/graphiql-explorer

For complicated schema, this addition to GraphiQL is a significant enhancement, particularly for discovery by third parties.

image

@tomchristie
Copy link
Member

We could consider a pull request for this sure. Is there a generic mechanism for adding plugins to the igraphql explorer, and should we be looking at doing this in a more general way to let users pick and choose what extensions they want?
Related to this: I think we should probably consider pushing the GraphQL support into an independent third party app now, rather than having it in the Starlette repo itself. Anyone particularly keen in taking on maintainership if we decided to do that?

@seandavi
Copy link
Author

seandavi commented Nov 6, 2019

I think a graphiql wrapper with config exposed from python would be a useful layer for a number of projects. As for graphql support, I agree that having it split out seems natural. I'm not claiming ownership here (time is limited, as for all of us), but I'll try to take a quick look to see how involved it is.
I would be interested to hear how much usage/interest there is in the graphql tooling within the starlette community.

@tomchristie
Copy link
Member

Related: #619

@JayH5
Copy link
Member

JayH5 commented Feb 5, 2021

Thank you for filing this issue. We have decided to deprecate GraphQL support within Starlette itself so I am going to close this issue. See #619.

@JayH5 JayH5 closed this as completed Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants