bug: TestClient no longer accepts json as a delete argument

[LorhanSohaky]

When they migrated from requests to httpx they forgot to add the json parameter.

TypeError: delete() got an unexpected keyword argument 'json'

https://github.com/encode/starlette/pull/1376/files

[euri10]

hello, a quick search : encode/httpx#1587

[Kludex]

You can also use https://github.com/Kludex/bump-testclient for the migration, if you want. 👀

[LorhanSohaky]

hello, a quick search : encode/httpx#1587

Sorry, I was looking for open discussions. But then shouldn't this migration be classified as breaking change and not just change?

[Kludex]

Since we are on zero version (0.x), any breaking or important change alters the minor (0.y.z -> 0.(y + 1).0). Which is what we did.

[LorhanSohaky]

I refer to the changelog
https://github.com/encode/starlette/releases/tag/0.21.0

[Kludex]

[...] your test suite will likely break. [...]

What were you expecting there?

[LorhanSohaky]

I'm just commenting because when I updated the fastapi version the tests broke, so I saw that they had updated the starlette version. So I searched the changelogs for breaking change or something similar, but I couldn't find it.

So I kept looking using "git diff" to find out what version it happened on

BREAKING CHANGE

• Replace requests with httpx in TestClient Replace HTTP client on TestClient from requests to httpx #1376.

[LorhanSohaky]

I could be wrong, but they usually put breaking changes like this

[Kludex]

Who are "they"?

[LorhanSohaky]

Who are "they"?

"they" = other libraries

[mehmetcanfarsak]

Hi,
I wrote an article about possible solutions and how to implement it
https://medium.com/@mehmetcanfarsak/solution-for-testclient-delete-payload-support-8ae12e153a3a