Fix test not passing in 32-bit architectures (fixes #2032) #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix #2032 |
Some architectures cannot hold values after 2038 year. This commit fixes the following tests, adjusting the expiring date for the cookies to a maximum year value of 2037: * test_set_cookie * test_expires_on_set_cookie
Kludex
approved these changes
Feb 11, 2023
|
Thank you! We are going to make a release on the 14th - in case it matters. |
aminalaee
pushed a commit
that referenced
this pull request
Feb 13, 2023
Some architectures cannot hold values after 2038 year. This commit fixes the following tests, adjusting the expiring date for the cookies to a maximum year value of 2037: * test_set_cookie * test_expires_on_set_cookie
|
why am I mentioned here? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some architectures cannot hold values after
2038 year.
This commit fixes the following tests, adjusting
the expiring date for the cookies to a maximum
year value of 2037:
The starting point for contributions should usually be a discussion
Simple documentation typos may be raised as stand-alone pull requests, but otherwise please ensure you've discussed your proposal prior to issuing a pull request.
This will help us direct work appropriately, and ensure that any suggested changes have been okayed by the maintainers.
test_set_cookieandtest_expires_on_set_cookie#2032