New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump __version__
to 0.20.4
#1713
Conversation
Ah yeah one of those. 😌 No big deal. Shall we figure out what needs fixing first, and discuss if there’s anything we want to do differently as a separate step? Should we just roll a 0.20.5 release, as the path of least resistence? |
If I’m correct there’s no 0.20.4 yet on PyPI. I had this case on personal projects before. We could:
Only works if master is not protected for admins, I believe… This should trigger the release pipeline again, which runs on tags. The release page on GitHub will update automatically with the new tag target. |
Just for reference, otherwise things get lost over time... Thanks @florimondmanca 🙏 |
Just for the record, what we have done:
|
Apologies folks, I take blame in this. Can we can check the tag against the |
We do check the tag on the publish workflow. That's why it was not published on PyPI.
Let's share this. 😅 |
@adriangb - Not at all. It's a team effort. Good to discover that resolving an incorrect GitHub release really is just a case of "delete the release, delete the tag". So I'm not too invested in if we want to put in place extra guards against this or not. Also, I don't think the One nice easy change we could make is to have the |
__version__
.I've done a lot of releases already, and I made this mistake.
Suggestions for this to not happen again:
bump
script that will bump the version on__version__
and create an entry on the changelog.__version__
.On this specific case, I'll have to delete the tag, and recreate it? I'm not sure I have rights to delete the tag... Or manual publish by @tomchristie...