fix type annotations in responses.py #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
reviewed
Jun 28, 2022
| @@ -112,7 +112,7 @@ def set_cookie( | |||
| httponly: bool = False, | |||
| samesite: typing.Optional[Literal["lax", "strict", "none"]] = "lax", | |||
| ) -> None: | |||
| cookie: http.cookies.BaseCookie = http.cookies.SimpleCookie() | |||
| cookie: "http.cookies.BaseCookie[str]" = http.cookies.SimpleCookie() | |||
There was a problem hiding this comment.
Why is this correct? I can see it fixes the issue with pyright, but I don't understand how a single argument works, as BaseCookie is a dict 🤔
There was a problem hiding this comment.
Are you asking why str is the correct type? Both key and value are str (from the function signature) and str made type checker happy so pretty sure str is correct.
There was a problem hiding this comment.
As pointed on our conversation outside GitHub... It's because of the definition on typeshed: https://github.com/python/typeshed/blob/544c7c963333a4a415b951f13a6a6bbec2421161/stdlib/http/cookies.pyi#L54
Thanks @adriangb 😗
Kludex
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding/fixing a couple minor typing nits in
responses.py