Add notes on "filename" form-data field #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
memsuser
commented
Jun 24, 2022
memsuser
commented
- Added notes about RFC-7578 and "filename" form-data part field treatment by Starlette
- Added small comment to file access example
- Initially raised as discussion Should "filename" parameter in `Content-Disposition: form-data` be mandatory??? #1703
* Added notes about RFC-7578 and "filename" form-data part field treatment by Starlette * Added small comment to file access example
Kludex
reviewed
Jun 24, 2022
Wrapped notes Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
|
This looks good to me! |
adriangb
approved these changes
Jun 25, 2022
|
How does it look on mkdocs? |
|
|
Kludex
reviewed
Jun 25, 2022
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
|
I don't think this note should be included before introducing the word Can't we add this note by the end of the section? |
|
Yep that makes sense! |
Kludex
reviewed
Jun 27, 2022
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Kludex
reviewed
Jun 27, 2022
Kludex
reviewed
Jun 27, 2022
Kludex
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.