New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing.Optional
on missing annotations
#1549
Conversation
I have a question why use |
It's just to comply with the current pattern you see around in the code. |
Understood, thanks |
…tte into chore/add-optional-to-none
I've added @adriangb Does your approval stands after my latest changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I think this is good. I gave this a scroll through, I didn't see anything wrong so if MyPy is happy, I'm happy. LGTM!
no_implicit_optional = True | ||
show_error_codes = True | ||
|
||
[mypy-starlette.testclient] | ||
no_implicit_optional = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 good call
There was a previous comment by @tomchristie about adding
typing.Optional
where is missing in a single PR.I can't find the comment.
Note: I need to add
no-implicit-optional
on mypy configuration.