Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunch of improvements on authentication documentation #1420

Merged
merged 4 commits into from Jan 18, 2022
Merged

Bunch of improvements on authentication documentation #1420

merged 4 commits into from Jan 18, 2022

Conversation

mkniewallner
Copy link
Contributor

AuthenticationBackend.authenticate signature was updated here to handle both HTTP and websocket protocols, but the documentation still uses request.

Also removing UnauthenticatedUser import in AuthenticationBackend example, as it is not used, and adding some missing imports in a few examples.

Side-note: The documention mixes single and double quotes usage for strings. Should a consistent style be used? Maybe https://github.com/asottile/blacken-docs could be helpful?

@Kludex
Copy link
Sponsor Member

Kludex commented Jan 18, 2022

Side-note: The documention mixes single and double quotes usage for strings. Should a consistent style be used? Maybe https://github.com/asottile/blacken-docs could be helpful?

I recommend a GitHub discussion or introducing the idea on our Gitter server.

Thanks for the PR! 🎉

@Kludex Kludex merged commit 3182495 into encode:master Jan 18, 2022
@mkniewallner mkniewallner deleted the improvements-authentication-documentation branch January 18, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants