Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.17.1 #1338

Merged
merged 2 commits into from Nov 17, 2021
Merged

Version 0.17.1 #1338

merged 2 commits into from Nov 17, 2021

Conversation

LarsStegman
Copy link
Contributor

@LarsStegman LarsStegman commented Nov 17, 2021

Changes: 0.17.0..master
GitHub Draft release: here

Copy link
Sponsor Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next steps:

  • @tomchristie needs to give you maintainer status,
  • Create the draft release.
  • Get this approved.
  • Create tag 0.17.1 and push it
  • Draft -> Release

docs/release-notes.md Outdated Show resolved Hide resolved
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
@tomchristie
Copy link
Member

tomchristie commented Nov 17, 2021

Invite sent.

As @Kludex says, once you're a maintainer, head over to the releases section, and create a new draft release...

Screenshot 2021-11-17 at 15 52 25

Make sure to hit the "save draft" button not the "publish release".

Screenshot 2021-11-17 at 15 51 13

And pop back to this thread so we can approve it.

Aside: It'd kinda be nice from my POV if GH had some more control over this process. Still find it a bit easy too easy get it unintentionally wrong.

I suppose we could alternately consider doing this process the other way around, and merging a release PR before we author the release stuff?

@LarsStegman
Copy link
Contributor Author

I have created the draft release

@tomchristie
Copy link
Member

@LarsStegman - Fab...

@LarsStegman LarsStegman merged commit 881af38 into encode:master Nov 17, 2021
@tomchristie
Copy link
Member

Hey presto! 🌟

It's not too bad our release process, eh? I'm sure we've got a few little improvements we could make to on boarding folks into maintainer-ship, and it'd be nice if this process had a few more guardrails perhaps, but pretty neat really, thanks to PyPI tokens & GitHub's actions support.

@LarsStegman
Copy link
Contributor Author

Yeah, it's quite an easy process. It's nice there is no hassle to get the version deployed to PyPI.

@LarsStegman LarsStegman deleted the release/0.17.1 branch November 17, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants