Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 0.17.0 #1324

Merged
merged 4 commits into from Nov 4, 2021
Merged

Version 0.17.0 #1324

merged 4 commits into from Nov 4, 2021

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Oct 28, 2021 •
edited

@florimondmanca florimondmanca mentioned this pull request Oct 28, 2021
Merged
@Kludex Kludex marked this pull request as ready for review October 28, 2021 17:28
@Kludex Kludex requested a review from a team October 28, 2021 17:28
@havardthom
Copy link

Will #1318 be in 0.17.0?

@Kludex
Copy link
Sponsor Member Author

Kludex commented Nov 1, 2021

@havardthom I can't reproduce #1284 against master after #1262 merge.

@Kludex Kludex mentioned this pull request Nov 2, 2021
Closed
2 tasks
florimondmanca
florimondmanca approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes and the compare log, looking good to me.

@Kludex
Copy link
Sponsor Member Author

Kludex commented Nov 4, 2021

Thanks @florimondmanca ! 😎

Just for the record, documentation and CI changes were not included on the changelog - in httpx that's written in the CONTRIBUTING.md, but we don't have contribution guidelines on starlette yet.

@Kludex Kludex merged commit 2b3f5e6 into encode:master Nov 4, 2021
@florimondmanca
Copy link
Member

florimondmanca commented Nov 4, 2021 •
edited

@Kludex Yup I think that's a good practice in general — only include changes that matter to code users. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

@graingert graingert Awaiting requested review from graingert

@JayH5 JayH5 Awaiting requested review from JayH5

@tomchristie tomchristie Awaiting requested review from tomchristie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kludex @havardthom @florimondmanca