🐛 Different Host behavior for setting host argument and getting Host header

[WhiteApfel]

Checklist

• The bug is reproducible against the latest release and/or master.
• There are no similar issues or pull requests to fix it yet.

Describe the bug

When adding a host-based routes, host value can accept the port and does not process it in any way. But Host.matches() cuts off the port number (routing.py:432)

Expected behavior

When adding, cut off the port, or сonsider it when matching.

Actual behavior

import uvicorn as uvicorn
from starlette.applications import Starlette
from starlette.responses import PlainTextResponse
from starlette.routing import Host, Router, Route

app = Starlette(routes=[
    Host('127.0.0.1:8889', app=Router(routes=[Route('/', lambda *a, **k: PlainTextResponse('Hello World'))])),
])

uvicorn.run(app, port=8889)

Breakpoint at routing.py:433

• Starlette version: 0.16.0

[WhiteApfel]

@aminalaee, maybe we should also cut off the port when matching host-based routes? As I understand it, the Host.host value is used to generate links via url_for, the port number may be useful there

[aminalaee]

@WhiteApfel I agree. I think that can be useful in host-based routing,

[WhiteApfel]

It might be cool to make the port handling principle similar to the subdomain principle