Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping this fixes #1212, but tbh it is a bit difficult to test. I can confirm that this warning when running
scripts/docs
is gone:...and that
sitemap.xml
makes sense when running locally. Currently, https://www.starlette.io/sitemap.xml has badloc
attributes (they're allNone
).w.r.t. the HTTPS redirect issue (there being no redirect), I don't have sufficient permissions on GitHub to fix that as per these instructions: https://docs.github.com/en/pages/getting-started-with-github-pages/securing-your-github-pages-site-with-https
I'm hoping that I can just run
mkdocs gh-deploy --force
after this is merged to deploy new docs but will see.