Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL integration does not work w/ graphl-core versions > 2 #1144

Closed
2 tasks done
mecampbellsoup opened this issue Mar 1, 2021 · 1 comment
Closed
2 tasks done

Comments

@mecampbellsoup
Copy link

Checklist

  • The bug is reproducible against the latest release and/or master.
  • There are no similar issues or pull requests to fix it yet.

Describe the bug

When following the Starlette GraphQL docs regarding GraphQL integration, if you install graphql-core versions > 2 (i.e. non-legacy core library), you will see that the module graphql.execution.executors.asyncio.AsyncioExecutor no longer exists.

I asked about this in the GraphQL core project and they indicated that as of graphql-core >=3 the executors had been discarded as they were now async by default, roughly speaking (I'm paraphrasing, please see the issue I linked to for context).

I didn't see any open issues regarding support for the new graphql-core versions - is this in the works, by any chance? The legacy project is now unsupported.

Environment

  • OS: Linux (by way of minikube)
  • Python version: 3.9.0
  • Starlette version: 0.13.16

Additional context

graphql-python/graphql-core#121
https://github.com/graphql-python/graphql-core-legacy

@Kludex
Copy link
Sponsor Member

Kludex commented Mar 1, 2021

Starlette deprecated built-in GraphQL support.

Check #1135 for more details.

@JayH5 JayH5 closed this as completed Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants