Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.14.2 #1133

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Version 0.14.2 #1133

merged 2 commits into from
Feb 2, 2021

Conversation

JayH5
Copy link
Member

@JayH5 JayH5 commented Feb 2, 2021

Fixed

@JayH5 JayH5 requested a review from a team February 2, 2021 19:35
Copy link
Member

@euri10 euri10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ! thanks @JayH5 . I have one minor comment, you can ignore if you disagree _)


### Changed

* Fixed `ServerErrorMiddleware` compatibility with Python 3.9.1/3.8.7 when debug mode is enabled -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a changelog pro but I'd put these 2 items under Fixed since the functionality does not change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I had a similar thought 😅 we've only used these subheadings recently and was trying to be consistent with how it's been done in the past. All of these fall under "Fixed", I think, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants