Version 0.14.1 #1088
Merged
Version 0.14.1 #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, this will actually have to wait till tomorrow unless somebody want to take it over. 😴 🛌 |
|
Looks fine to me. I'd probably include a link in the changelog to the documentation that teaches people how to build their own? |
florimondmanca
previously approved these changes
Nov 8, 2020
JayH5
commented
Nov 9, 2020
JayH5
requested review from
florimondmanca and
a team
and removed request for
erewok and
florimondmanca
JayH5
dismissed
florimondmanca’s stale review
Changes, think they need re-review.
euri10
approved these changes
Nov 9, 2020
|
|
||
| ### Removed | ||
|
|
||
| * `UJSONResponse` was removed (this change was intended to be included in 0.14.0). Please see the |
There was a problem hiding this comment.
The additional hint is nice; could we please still add the PR number, for the sake of traceability? (This is what I meant in my last suggestion adding Pull #N. I find they make it easier to find back the set of changes and provide an additional way to evaluate what actually changed.)
There was a problem hiding this comment.
Agree. Was going for brevity/similarity to previous changelog entries, but will rather go for (succinct) detail in the future 👍.
erewok
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
UJSONResponsewas removed (this change was intended to be included in 0.14.0).