Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 0.13.8 #1026

Merged
merged 4 commits into from Aug 14, 2020
Merged

Version 0.13.8 #1026

merged 4 commits into from Aug 14, 2020

Conversation

erewok
Copy link
Contributor

@erewok erewok commented Aug 11, 2020

  • Revert Queue maxsize fix in BaseHTTPMiddleware.
  • Staticfiles constructor now allows pathlib.Path (in addition to str) for directory keyword arg.

@erewok
Version 0.13.8 release
c087c38 
Revert Queue maxsize fix in BaseHTTPMiddleware
@erewok
Reword reasoning for reverted change
b4f74cb
@erewok erewok mentioned this pull request Aug 11, 2020
Closed
@JayH5
Copy link
Member

JayH5 commented Aug 11, 2020

IMO the change to maxsize of the queue should be a separate PR or at least have an issue about the problem. I understand this was discussed in gitter, but that doesn't provide a good record of why changes were made, especially without a link to that discussion. I'd rather have the changelog link to that issue than trying to explain the problem fully in the changelog.

@erewok
Copy link
Contributor Author

erewok commented Aug 11, 2020 •
edited

You're right @JayH5. Further, a separate PR for that change would give others more of a chance to comment on it as well. People are unlikely to see it here. Here's a PR with only that change: #1028

@erewok erewok marked this pull request as draft August 11, 2020 19:55
@erewok erewok marked this pull request as ready for review August 13, 2020 12:50
@erewok
Copy link
Contributor Author

erewok commented Aug 13, 2020

This PR has been updated to include only release notes and version bump.

florimondmanca
florimondmanca reviewed Aug 13, 2020
View reviewed changes
docs/release-notes.md Outdated Show resolved Hide resolved
docs/release-notes.md Outdated Show resolved Hide resolved
@erewok erewok merged commit 31ad4e5 into master Aug 14, 2020
@erewok erewok deleted the version-0.13.8 branch August 14, 2020 03:48
@Kludex Kludex mentioned this pull request Jan 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erewok @JayH5 @florimondmanca