Use os.PathLike in StaticFiles for directory #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kevinastone. This looks like a good addition. Thank you for putting it together. As part of this PR, would you be up for updating the documentation on staticfiles to include a note or two on using In addition, can you pull latest master into your branch? Thanks again! |
This allows using `pathlib.Path` in addition to `str` for configuring the base directory of the static files in line with how python3.6+ handles filesystem operations. Fixes encode#1004
erewok
approved these changes
Aug 5, 2020
|
Thanks again! |
em92
added a commit
to em92/starlette
that referenced
this pull request
Sep 11, 2020
This reverts commit 9387832.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using
pathlib.Pathin addition tostrfor configuringthe base directory of the static files in line with how python3.6+
handles filesystem operations.
Fixes #1004