Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad exception name in TestClient documentation #1000

Merged
merged 2 commits into from Jul 15, 2020
Merged

Fix bad exception name in TestClient documentation #1000

merged 2 commits into from Jul 15, 2020

Conversation

hellocoldworld
Copy link
Contributor

The documentation warns about a Disconnect exception being raised, however the proper name of the exception is WebSocketDisconnect

@hellocoldworld
Update testclient.md
280e625 
Fix bad exception name
florimondmanca
florimondmanca approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Dunno if I can merge this, let's see...

@florimondmanca
Copy link
Member

Checks are failing due to isort 5 breaking changes...

@florimondmanca florimondmanca merged commit 14139c2 into encode:master Jul 15, 2020
@florimondmanca
Copy link
Member

Thanks @hellocoldworld!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hellocoldworld @florimondmanca