-
|
Up until Starlette version 0.32.0.post1 the following code works as expected: # pip install starlette==0.32.0.post1 python-socketio
import socketio
from starlette.applications import Starlette
from starlette.responses import HTMLResponse
from starlette.routing import Route
async def homepage(_):
return HTMLResponse("""
<!DOCTYPE html>
<html>
<head>
<title>SocketIO Test</title>
<script src="https://cdn.socket.io/4.7.3/socket.io.min.js"></script>
<script type="text/javascript">
document.addEventListener('DOMContentLoaded', (event) => {
var socket = io("/", { path: "/ws/socket.io" });
socket.on('msg', function(msg) {
document.body.innerHTML = '<h1>' + msg + '</h1>';
});
});
</script>
</head>
<body>
<h1>Connecting to SocketIO...</h1>
</body>
</html>
""")
sio = socketio.AsyncServer(async_mode='asgi', cors_allowed_origins='*')
sio_app = socketio.ASGIApp(socketio_server=sio, socketio_path='socket.io')
app = Starlette(routes=[Route("/", homepage)])
app.mount('/ws', sio_app)
@sio.on('connect')
async def handle_connect(sid, *args, **kwargs):
await sio.emit('msg', 'Hello from Starlette!')After establishing the connection the website shows "Hello from Starlette!". But when upgrading to Starlette 0.33.0 or greater, the |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 6 replies
-
|
Looks like Starlette 0.32.0.post1 passed sio_app = socketio.ASGIApp(socketio_server=sio, socketio_path='/ws/socket.io')But why has the parameter changed in 0.33.0 and was it intentional? |
Beta Was this translation helpful? Give feedback.
-
|
If you try the version But yeah, it was intentional. |
Beta Was this translation helpful? Give feedback.
-
|
If that, being a breaking API change, was intentional then should there not have been a major version increase? |
Beta Was this translation helpful? Give feedback.
-
No. The change was intentional, but it's not a breaking change, it was a bug fix. Also, we don't follow SemVer yet, we follow ZeroVer (which is not important, since this would have been a minor anyway). Please check |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
Correct. |
Beta Was this translation helpful? Give feedback.
-
|
A change to an API that breaks depending code pretty much is the definition of a breaking change, right? If it also happens to fix an earlier mistake than that just also makes it a bugfix. The two are not mutually exclusive. |
Beta Was this translation helpful? Give feedback.
0.35.1still has the full path inscope['path']. But as I understand from #2400 this is actually the ASGI standard. Therefore packages like fastapi-socketio, NiceGUI etc. which mount sub apps need to be adapted. Right?