warn for missing .env file?

[mathause]

Config(".env") 'fails' silently if the file does not exist. Should this raise an error or give an informative warning? I think that might be helpful if you forget to create your .env on the production server.

starlette/starlette/config.py

Line 62 in bc90057

if env_file is not None and os.path.isfile(env_file):

from starlette.config import Config
Config(".env")

[Kludex]

PR welcome.

[timombre]

Was raising an error implemented ? Deployment pipeline has crashed when fastapi (which has starlette as a dependency) released a new version.

tests/conftest.py:9: in
from app.main import app
app/main.py:12: in
from starlette_authlib.middleware import AuthlibMiddleware as SessionMiddleware
newenv/lib/python3.11/site-packages/starlette_authlib/middleware.py:31: in
config = Config(".env")
newenv/lib/python3.11/site-packages/starlette/config.py:65: in init
raise FileNotFoundError(f"Config file '{env_file}' not found.")
E FileNotFoundError: Config file '.env' not found.

[PeterJCLaw]

It would be great if the release notes could call this out as a (breaking) change. In my project I used to use Config('.env') as a way to allow for an optional config file (I have suitable defaults in place) and e.g: in CI tests I don't have a .env file. With this change I (and anyone using this behaviour) will need to manually reimplement the file check (incurring IO races along the way).

Perhaps a better solution would be to have a warning if the file is missing? Or to have classmethods on Config which allow for different expectations? So like Config.with_required_file('.env'), Config.with_optional_file('.env'); perhaps leaving Config(...) not accepting a file at all.

In case useful to others I'm now doing this:

try:
    config = Config('.env')
except FileNotFoundError:
    config = Config()

[bengabp]

is this implemented now ?

[Kludex]

Didn't we revert this, and use warning instead of error? or something...