Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

Proxy support #7

Closed
tomchristie opened this issue Mar 21, 2019 · 6 comments
Closed

Proxy support #7

tomchristie opened this issue Mar 21, 2019 · 6 comments

Comments

@tomchristie
Copy link
Member

I'd assume this is probably currently broken, but haven't looked into it yet.

Questions:

  • Can anyone confirm if it is currently broken?
  • Where does the error occur if so?
  • What API in requests do we need to be honoring?
  • Where does requests handle proxy connections?
@oldani
Copy link

oldani commented Mar 22, 2019

I will check this out.

@blueyed
Copy link
Contributor

blueyed commented Apr 18, 2019

It does not work currently.
It gets passed into requests_async.adapters.send, but is not used there.

It looks like passing in a sock with a configured proxy (sock.set_proxy) to create_connection might be a solution.

@cmeadows
Copy link

cmeadows commented May 1, 2019

Now with the updated httpcore version, is this on the docket to be added?

@tomchristie
Copy link
Member Author

In due course yup.

@cmeadows
Copy link

cmeadows commented May 1, 2019

Great! I’m not too terribly familiar with the codebase of httpcore or requests but more than happy to contribute if needed!

@tomchristie
Copy link
Member Author

Closing this one off, in favour of encode/httpx#36, since the work will actually be within http3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants