New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requests for new public APIs #3176
Comments
Thanks @karpetrosyan
So... I'm not necessarily(?) convinced that's the outcome I'd like to see here. For example, switching to the following* seems clearer to me... url : httpx.URL | str,
headers: httpx.Header | Mapping[str, str] | Sequence[Tuple[str, str]],
params: httpx.QueryParams | Mapping[str, str] | Sequence[Tuple[str, str]],
... * useful starting point for discussion |
I'm curios why not just expose from httpx.types import HeaderTypes, QueryParamsTypes, URLTypes
...
url : URLTypes | str,
headers: HeaderTypes | Mapping[str, str] | Sequence[Tuple[str, str]],
params: QueryParamsTypes | Mapping[str, str] | Sequence[Tuple[str, str]],
... |
Mostly I think these types end up obscuring the actual API and are code smells that should be squished. |
Ref: encode/starlette#2534 (comment)
This issue was opened to resolve all kinds of problems where third-party packages may need to use private imports. We should definitely expose them to avoid problems like #3130 (comment).
I will include the package name along with its private imports (only starlette for now), so we can clearly identify what needs to be exposed.
Note that:
We can also add other packages as well to track all of them in this issue.
Starlette
The text was updated successfully, but these errors were encountered: