Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use httpx public API for 'test_content' tests. #2494

Merged
merged 2 commits into from Dec 6, 2022
Merged

Use httpx public API for 'test_content' tests. #2494

merged 2 commits into from Dec 6, 2022

Conversation

tomchristie
Copy link
Member

Switch the tests in test_content.py to use httpx.Request(...) and httpx.Response(...) instead of testing an internal function directly.

Refs #2492

@tomchristie tomchristie added the refactor Issues and PRs related to code refactoring label Dec 6, 2022
@tomchristie tomchristie merged commit 71a1589 into master Dec 6, 2022
@tomchristie tomchristie deleted the test-content-should-use-public-api branch December 6, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
refactor Issues and PRs related to code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomchristie @Kludex