Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpx cli --proxy and --proxies option problem #2124

Closed
guyskk opened this issue Mar 14, 2022 · 3 comments · Fixed by #2125
Closed

httpx cli --proxy and --proxies option problem #2124

guyskk opened this issue Mar 14, 2022 · 3 comments · Fixed by #2125
Labels
docs Changes to the documentation

Comments

@guyskk
Copy link
Contributor

guyskk commented Mar 14, 2022

The httpx --help shows --proxy option, but actually it accepts --proxies option.

Which is correct? Is there an undocumented change from--proxy to --proxies?

@guyskk
Copy link
Contributor Author

guyskk commented Mar 14, 2022

And is there a standalone repo of httpx cli in the history? I remember I submitted an issue but can not find it.

@florimondmanca
Copy link
Member

@guyskk AFAIK, no, httpx-cli is now integrated into this repository, with code in httpx/_main.py.

I assume the correct option is proxies, since that is what the CLI accepts and also what the Client accepts: Client(proxies=...). Would you like to submit a fix?

@florimondmanca florimondmanca added the docs Changes to the documentation label Mar 14, 2022
guyskk added a commit to guyskk/httpx that referenced this issue Mar 14, 2022
@guyskk
Copy link
Contributor Author

guyskk commented Mar 14, 2022

@florimondmanca Thank you! PR submitted #2125 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Changes to the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants