Skip to content

Preserve Authorization header on HTTPS redirect (#1850) #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Preserve Authorization header on HTTPS redirect (#1850) #2074

merged 2 commits into from
Feb 9, 2022

Conversation

waterfountain1996
Copy link
Contributor

@waterfountain1996 waterfountain1996 commented Feb 9, 2022

Closes #1850

Added a utility function to check if a URL is a HTTPS upgrade of another URL. It will only work if the default ports (80 and 443) are used.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@tomchristie
Copy link
Member

Fantastic - very neatly done.

@tomchristie tomchristie merged commit 4401d55 into encode:master Feb 9, 2022
@tomchristie tomchristie mentioned this pull request May 9, 2022
samclearman pushed a commit to titanmsp/httpx that referenced this pull request Apr 26, 2025
…#2074)

* Preserve Authorization header on HTTPS redirect (encode#1850)

* Update httpx/_client.py

Co-authored-by: Tom Christie <tom@tomchristie.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Authorization header to be preserved on http->https redirect cases.
2 participants