Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Python 3.10 in the CI #1886

Merged
merged 2 commits into from Oct 6, 2021
Merged

Bump Python 3.10 in the CI #1886

merged 2 commits into from Oct 6, 2021

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Oct 5, 2021

No description provided.

@tomchristie
Copy link
Member

So.... we really can't do anything until we've resolved this 3.9 nonsense.
Next step - figure out our workaround for that.

@Kludex
Copy link
Sponsor Member Author

Kludex commented Oct 6, 2021

The issue seems like the server doesn't start in the tests (running with --full-trace).

    @pytest.fixture(scope="session")
    def server():
        config = Config(app=app, lifespan="off", loop="asyncio")
        server = TestServer(config=config)
>       yield from serve_in_thread(server)

tests/conftest.py:288: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

server = <tests.conftest.TestServer object at 0x7faee6915b20>

    def serve_in_thread(server: Server):
        thread = threading.Thread(target=server.run)
        thread.start()
        try:
            while not server.started:
>               time.sleep(1e-3)
E               KeyboardInterrupt

tests/conftest.py:277: KeyboardInterrupt

I don't see what could have caused this: https://www.python.org/downloads/release/python-397/

EDIT: Running ./scripts/test tests/test_api.py gives us a hint.

@tomchristie tomchristie merged commit 2212dda into master Oct 6, 2021
@tomchristie tomchristie deleted the Kludex-patch-3 branch October 6, 2021 09:13
@tomchristie
Copy link
Member

Aight, sorted. 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants