How to get server IP from Httpx get response

[ElliotGarbus]

How should I get the server IP address from the Httpx get response?
I have not found an answer in the docs. This stack overflow question, https://stackoverflow.com/questions/73934230/get-server-ip-from-response-of-httpx-get , provides the rather implementation dependent solution:

import httpx

with httpx.Client() as hc:
    r = hc.get("https://httpbin.org/get")
    peername = r.stream._stream._httpcore_stream._stream._connection._network_stream._sock.getpeername()
    print(r.json())
    print(peername)

Is there a better way?

[ElliotGarbus]

Answering my own question... The trio library provides an async sockets implementation. I will use that.
see; https://trio.readthedocs.io/en/stable/reference-io.html#trio.socket.getaddrinfo

[tomchristie]

Is there a better way?

There is a better way, yes...

That answer is digging into private API, so don't expect it to be resilient.

We do provide a response extension which gives a public API onto this information.
It is currently only documented in the low level httpcore library docs, here... https://www.encode.io/httpcore/extensions/#extra-network-information
But we should also document it, since it's available through httpx too.

See issue #2599

Adapting your example to include the server address info...

import httpx

with httpx.Client() as client:
    with client.stream("GET", "https://httpbin.org/get") as response:
        network_stream = response.extensions["network_stream"]
        server_addr = network_stream.get_extra_info("server_addr")
        print(response.json())
        print(server_addr)

Notice that we're using stream here so that we've got a context where the network connection guaranteed to still available at the point we're inspecting the server address. If we used a client.get() then the network connection might or might not still be open after we've read the response.

[tomchristie]

Note also that this API ought to work fine for any of the sync, asyncio, or trio variants.

(Although the code would look a little different for the async cases)

[robe1149]

Thank you for this!!

[ElliotGarbus]

Many thanks!