Revert "Fix async cancellation behaviour" #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ce8f872.
Kludex
approved these changes
Nov 25, 2022
This was referenced Nov 25, 2022
Merged
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts pull request #580.
Any accesses to modifying
._poolor._requestsshould always be guarded by first holding the._pool_lock.Pull request #580 was the wrong approach to resolving #564.
Closes #613, #615, #621, #624.
Reopens #564 - this is a lower priority bug. I believe I have the correct approach to resolving this, but will follow up with it separately to this pull request.