Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check system when connecting to UNIX socket #619

Merged
merged 1 commit into from Nov 21, 2022
Merged

Check system when connecting to UNIX socket #619

merged 1 commit into from Nov 21, 2022

Conversation

michaeloliverx
Copy link
Member

@michaeloliverx michaeloliverx commented Nov 21, 2022 •
edited

Should we add a test that only runs on Windows and add windows to CI?

Closes: #617

@michaeloliverx michaeloliverx marked this pull request as ready for review November 21, 2022 13:20
@tomchristie
Copy link
Member

Should we add a test that only runs on Windows and add windows to CI?

Nah.

@michaeloliverx michaeloliverx merged commit a2f86ca into encode:master Nov 21, 2022
@michaeloliverx michaeloliverx deleted the michaeloliverx/issue617 branch November 21, 2022 13:36
@tomchristie tomchristie mentioned this pull request Nov 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gracefully handle trying to connect to a UNIX socket on Windows
2 participants
@michaeloliverx @tomchristie