Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of deprecated socket.error > OSError #609

Merged
merged 2 commits into from Nov 17, 2022
Merged

Replace use of deprecated socket.error > OSError #609

merged 2 commits into from Nov 17, 2022

Conversation

michaeloliverx
Copy link
Member

As discussed in #607, leave socket.timeout alone.

@tomchristie
Copy link
Member

Nice one, yup. 👍

@tomchristie tomchristie merged commit c316f63 into encode:master Nov 17, 2022
@tomchristie tomchristie mentioned this pull request Nov 17, 2022
Closed
@michaeloliverx michaeloliverx deleted the michaeloliverx/issue607 branch November 17, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaeloliverx @tomchristie