Handle 1xx interim response codes #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This discussion on httpx indicates that the latest
httpcoreversion has introduced a change in behaviour for "100 Continue" status codes.This highlights that #581 has fixed our behaviour for "101 Switching Protocols" which is a final response code. But breaks our behaviour for "100 Continue", "102 Processing", and "103 Early Hints" statues codes, which are all interim response codes.
Our behaviour for now ought to treat any
1xxresponse codes as interim responses, with the exception of "101 Switching Protocols".Note that in this PR I've only added tests for 100 and 103, since that's sufficient.
We could feasibly have additional smarts around how we deal with the interim cases. For example we could defer sending request bodies on "Expect: continue" requests, until we see a "100 continue". But that's really a different story.