httpcore/backends/trio: map OSError exceptions #543
Conversation
The underlying socket implementations can raise OSError for situations such as `getaddrinfo` failing to resolve an address. Previously, these errors would not be mapped to httpcore exception types for the trio backend. Now, map OSError exceptions in the trio backend to ConnectError. This will make trio consistent with the asyncio backend. Signed-off-by: Vincent Fazio <vfazio@xes-inc.com>
|
@tomchristie @michaeloliverx Just tagging since I saw you two were the last to touch this file. If there are concerns, please let me know. |
|
@vfazio Is there a simple reproduction case of when this I'm wondering whether this should be treated as an httpcore issue, or a trio issue: shouldn't trio be handling it and wrapping it in a ConnectError or something? |
@florimondmanca asyncio and trio raise an https://github.com/encode/httpcore/blob/master/httpcore/backends/asyncio.py#L104 |
Closes #544
The underlying socket implementations can raise OSError for situations
such as
getaddrinfofailing to resolve an address.Previously, these errors would not be mapped to httpcore exception types
for the trio backend.
Now, map OSError exceptions in the trio backend to ConnectError.
This will make trio consistent with the asyncio backend.
Signed-off-by: Vincent Fazio vfazio@xes-inc.com