Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping Python 3.6 support #515

Closed
michaeloliverx opened this issue Mar 1, 2022 · 1 comment · Fixed by #535
Closed

Consider dropping Python 3.6 support #515

michaeloliverx opened this issue Mar 1, 2022 · 1 comment · Fixed by #535
Assignees

Comments

@michaeloliverx
Copy link
Member

Python 3.6 is now considered legacy1, we should remove support and drop any compatibility shims in place:

# `contextlib.asynccontextmanager` exists from Python 3.7 onwards.
# For 3.6 we require the `async_generator` package for a backported version.
try:
from contextlib import asynccontextmanager # type: ignore
except ImportError:
from async_generator import asynccontextmanager # type: ignore # noqa

Footnotes

  1. The release you are looking at is Python 3.6.0, the initial feature release for the legacy 3.6 series which has now reached end-of-life and is no longer supported.

@tomchristie
Copy link
Member

Yup to this, given encode/httpx#2097.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants