Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mypy from 0.910 to 0.930 #461

Merged
merged 5 commits into from
Jan 5, 2022
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 1, 2022

Bumps mypy from 0.910 to 0.930.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 1, 2022
Bumps [mypy](https://github.com/python/mypy) from 0.910 to 0.930.
- [Release notes](https://github.com/python/mypy/releases)
- [Commits](python/mypy@v0.910...v0.930)

---
updated-dependencies:
- dependency-name: mypy
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/mypy-0.930 branch from c241c27 to b7771d0 Compare January 1, 2022 12:49
@tomchristie
Copy link
Member

This is a good example of a case where the infrastructure around Python's typing can sometimes create non-valuable busy work. Whatever's changed here wrt. either a new version of mypy or a new version of the trio_typing package, it's not adding anything of value to us.

Here's the error that's causing the CI to fail...

Error importing plugin "trio_typing.plugin": cannot import name 'TypeVarDef' from 'mypy.types'

Going to dig into resolving this.

@tomchristie
Copy link
Member

One part of this CI failure was addressed by #469.

There's also another set of mypy errors introduced by this update:

httpcore/backends/sync.py:24: error: Argument 1 to "map_exceptions" has incompatible type "Dict[Type[OSError], Type[Exception]]"; expected "Mapping[Type[Exception], Type[Exception]]"
httpcore/backends/sync.py:33: error: Argument 1 to "map_exceptions" has incompatible type "Dict[Type[OSError], Type[Exception]]"; expected "Mapping[Type[Exception], Type[Exception]]"
httpcore/backends/sync.py:49: error: Argument 1 to "map_exceptions" has incompatible type "Dict[Type[OSError], Type[Exception]]"; expected "Mapping[Type[Exception], Type[Exception]]"
httpcore/backends/sync.py:75: error: Argument 1 to "map_exceptions" has incompatible type "Dict[Type[OSError], Type[Exception]]"; expected "Mapping[Type[Exception], Type[Exception]]"
httpcore/backends/sync.py:85: error: Argument 1 to "map_exceptions" has incompatible type "Dict[Type[OSError], Type[Exception]]"; expected "Mapping[Type[Exception], Type[Exception]]"

I've addressed that by easing up the type signature on map_exceptions.

@tomchristie tomchristie merged commit 14e9162 into master Jan 5, 2022
@tomchristie tomchristie deleted the dependabot/pip/mypy-0.930 branch January 5, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant