Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov #7908

Open
adamchainz opened this issue Apr 6, 2021 · 17 comments
Open

Fix codecov #7908

adamchainz opened this issue Apr 6, 2021 · 17 comments
Assignees

Comments

@adamchainz
Copy link
Contributor

During #7903 I realized that codecov doesn't seem to be installed correctly - it's not reporting status back on PR's, although it does have the data: https://app.codecov.io/gh/encode/django-rest-framework/compare/7903

It may need reinstalling via the GitHub Marketplace - it could have been installed with the legacy GitHub integrations system rather than as a "GitHub App".

@adamchainz
Copy link
Contributor Author

@carltongibson do you have access to this?

@carltongibson
Copy link
Collaborator

@adamchainz. Nope. Let's call in the cavalry. 🐎 @tomchristie

@tomchristie
Copy link
Member

What do I need to do, where?

@adamchainz
Copy link
Contributor Author

Remove codecov from the legacy integrations in the repo settings. Login to codecov and set it up again. Then retrigger the CI run on the master branch.

@stale
Copy link

stale bot commented Apr 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 30, 2022
@tomchristie
Copy link
Member

Nobody is shouting at me. Let's close it.
Maybe everything is fine now. 🤷‍♂️

@adamchainz
Copy link
Contributor Author

I still don't see codecov reports for the latest commit on the main branch?

@tomchristie tomchristie reopened this Aug 3, 2022
@stale stale bot removed the stale label Aug 3, 2022
@tomchristie
Copy link
Member

Ok, thanks @adamchainz.

I guess <mumbles grumpily>

😉

@stale
Copy link

stale bot commented Nov 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 1, 2022
@auvipy
Copy link
Member

auvipy commented Nov 30, 2022

should we consider https://github.com/codecov/codecov-action? Been using it in some of the projects I maintain

@stale stale bot removed the stale label Nov 30, 2022
@tomchristie
Copy link
Member

I'd prefer we avoid adding tooling if possible at this point. We're likely just giving ourselves work to do.

@leogregianin
Copy link
Contributor

Latest commits already appear in codecov https://app.codecov.io/gh/encode/django-rest-framework/commits
Isn't it time to close this issue?

@stale
Copy link

stale bot commented Apr 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 2, 2023
@auvipy
Copy link
Member

auvipy commented Apr 13, 2023

in a recent PR it is failing to install codecov https://github.com/encode/django-rest-framework/actions/runs/4688723455/jobs/8309577776?pr=8943

pip install --upgrade codecov doesn't work anymore. so I believe we should switch to codecov gha

https://community.codecov.com/t/codecov-yanked-from-pypi-all-versions/4259/5

@stale stale bot removed the stale label Apr 13, 2023
@auvipy auvipy self-assigned this Apr 13, 2023
@auvipy auvipy added this to the 3.15 milestone Apr 13, 2023
@auvipy auvipy added the Cleanup label Apr 13, 2023
@adamchainz
Copy link
Contributor Author

codecov yanked the package: https://about.codecov.io/blog/message-regarding-the-pypi-package/

@auvipy
Copy link
Member

auvipy commented Apr 15, 2023

yes

@auvipy auvipy removed this from the 3.15 milestone Jul 11, 2023
@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants