Declare Django versions in install_requires #7063
Conversation
Pip's dependency resolver (used in pipenv, pip-compile, poetry, etc.) can use this to infer whether there's a verison collision in what it's being asked to install or not.
|
We've avoided including a hard django package dependency in the past. I expect we have users who're doing things like running against a custom django codebase, that's just installed locally, rather than using a PyPI version. I like the change for most users, but I think it might bite us. |
|
I've not had a complaint in django-cors-headers, at least since I added the requirement in March. The (small) problem I ran into was the Scout test suite which runs from Django 1.8 to 3.0 (😱) was always pulling the latest DRF because there are no restrictions, and I had to go read the changelog to add the correct version pins for each environment. |
|
I'd be -1 on enforcing a maximum supported version, but otherwise think this makes sense.
So long as their package is also named |
Fair. |
|
Let's do it. Thanks! |
* Declare Django versions in install_requires Pip's dependency resolver (used in pipenv, pip-compile, poetry, etc.) can use this to infer whether there's a verison collision in what it's being asked to install or not. * No max
* Declare Django versions in install_requires Pip's dependency resolver (used in pipenv, pip-compile, poetry, etc.) can use this to infer whether there's a verison collision in what it's being asked to install or not. * No max
Description
Pip's dependency resolver (used in pipenv, pip-compile, poetry, etc.) can use this to infer whether there's a verison collision in what it's being asked to install or not.