Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit_choices_to and Q objects #6470

Closed
4 of 6 tasks
vasdee opened this issue Feb 24, 2019 · 1 comment
Closed
4 of 6 tasks

limit_choices_to and Q objects #6470

vasdee opened this issue Feb 24, 2019 · 1 comment

Comments

@vasdee
Copy link

vasdee commented Feb 24, 2019

After upgrading from 3.8 -> 3.9 I've encountered an issue with the new limit_choices_to foreign key changes.

filter() argument after ** must be a mapping, not Q

It seems the issue was documented in the original merge and a fix was proposed but I can't find an existing PR that has addressed it - nor does the proposed fix exist in master

#6371 (comment)

Checklist

  • I have verified that that issue exists against the master branch of Django REST framework.
  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • This is not a usage question. (Those should be directed to the discussion group instead.)
  • This cannot be dealt with as a third party library. (We prefer new functionality to be in the form of third party libraries where possible.)
  • I have reduced the issue to the simplest possible case.
  • I have included a failing test as a pull request. (If you are unable to do so we can still accept the issue.)

Steps to reproduce

model with FK that contains a limit_choices_to with Q object reference ( instead of Dictionary)

Expected behavior

no errors, code works as expected if a dictionary is passed instead

Actual behavior

error thrown,

filter() argument after ** must be a mapping, not Q
@tomchristie
Copy link
Member

Okay - we'd happily consider a pull request based on dogukantufekci@607059d

carltongibson added a commit to carltongibson/django-rest-framework that referenced this issue Feb 25, 2019
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this issue Nov 17, 2020
sigvef pushed a commit to sigvef/django-rest-framework that referenced this issue Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants