Allow run_validators() to handle non-dict types. #6365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carltongibson
changed the title
Fixes encode#6053. Original test case thanks to Vincent Delaitre in encode#6242.
carltongibson
force-pushed
the
391/fix-6053
branch
from
6a7ba11
to
1dfd4d6
Compare
auvipy
approved these changes
Dec 20, 2018
|
Huffs grumpily OKAY FINE Seriously tho, yeah cool. Probably makes sense given the feedback on that ticket. Thanks fella. |
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
Fixes encode#6053. Original test case thanks to Vincent Delaitre in encode#6242.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6053.
to_internal_value()is expected to return a dict. #5922 relied on this, but users are implementing custom serialisers that return application objects[*]. This PR bypasses the read-only defaults handling for non-dict objects.[*]: This is why static typing will never work for Python 馃榾
Original test case thanks to @vdel in #6242.